https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37796
Nick Clemens (kidclamp) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #16 from Nick Clemens (kidclamp) <[email protected]> --- (In reply to Marcel de Rooy from comment #13) > What happens where, is not that trivial in the Serials module.. > The commit message says: > "When the patter is translated ot words, we need to do this from the date of > the next issue, so we must pass in the next published date" > > GetNextSeq used planneddate before: > - my $dt = dt_from_string($planneddate); > + my $dt = dt_from_string($nextpublisheddate); > > But the planneddate passed was $expected->{publisheddate} coming from the > GetNextExpected sub. Which uses: > $nextissue->{$_} //= strftime( '%Y-%m-%d', localtime ); > > Could you please explain how this went wrong previously? The planneddate > comes from a date field in the serial table or is defaulted to a ISO date. > > Wondering if we solve the issue in the right place? I generate the next published date earlier, but only so it can be passed into the sub GetNextSeq, planned date is still passed and didn't use this value previously, so I am not affecting that use. In bug 36546 I additionally used 'planneddate' for calculating the date parts of the serial, I was wrong ;-) This change only affects the issue number calculation as it relates to date parts, the test plan should cover the change here and illustrate the problem -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
