https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27834
--- Comment #23 from Marcel de Rooy <[email protected]> --- QUESTIONS The longer I look at the code, the more I am wondering how we should use the second rule with patron_maxissueqty. The current code feels like a bug. If that rule (with or without a specific patron category) is on branch level, I can understand that we might want to apply CircControl logic. But if it is on global level, I am convinced that we should not (just as we do for the first rule btw). By removing the filter, we apply a global cap as any user will intuitively understand the rule. I am not sure about the reason why PatronLibrary uses all patron checkouts when a branch level rule is applied. It feels inconsistent at the least. It makes more sense to me to apply item.hold_or_holdingbranch eq patronbranch here. And on global level use all checkouts as is done already. Same for the second patron_maxissueqty rule with PatronLibrary: at branch level apply the same filter, at global level look at all checkouts. Another thing is the coupling of calendar and circ rules. The example of Ray seems to illustrate that you might want to set them differently. This surely should be on a new report. Opening up a new report 41280 too for looking at the first two of these points (not disturbing this one too much). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
