https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27286
--- Comment #8 from David Nind <[email protected]> --- (In reply to Saiful Amin from comment #7) > > Result: > > [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt > > FAIL tidiness > > File is not tidy, please run `perl misc/devel/tidy.pl > > koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt` > > [PASS] tools/picture-upload.pl > > > > > > 2. I don't think it is necessary to have the comment "# Fix bug 27286" in > > the patch. > > Do I need to resubmit the patch with the changes recommended or is the QA > team allowed to do these changes themselves? The QA Team would normally ask you to make these changes. Add these in a follow-up patch - see https://wiki.koha-community.org/wiki/Commit_messages#Follow-ups For example: Bug 27286: (follow-up) Tidy code and remove comment -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
