https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes placing holds release notes| |when using ILS-DI - the | |value set in maxreserves | |(for example 1) was | |ignored, and you could | |place more holds than | |maxreserves. | | | |Note: When placing holds | |using the OPAC or staff | |interface, the value set in | |maxreserves is taken into | |account. (That is, you | |can't place more holds than | |what is set in maxreserves | |using the OPAC or staff | |interface.) Status|Needs Signoff |Failed QA --- Comment #143 from David Nind <[email protected]> --- The patches still apply, however the tests no longer pass (which is probably not surprising 8-)). Testing notes (using KTD): 1. Enable the ILS-DI system preference 2. Add 0.0.0.0/0 to the ILS-DI:AuthorizedIPs system preference 3. Set the maxreserves system preference to 1 4. Place holds with ILS-DI (Henry, Midway) - you should only be able to place 1, but you can place as many holds as you like: - Hold 1 (Bleak House): http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=19&bib_id=15&request_location='127.0.0.1' - Hold 2 (Programming the Perl DBI): http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=19&bib_id=13&request_location='127.0.0.1' - Hold 3 (The definitive guide to Catalyst): http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=19&bib_id=146&request_location='127.0.0.1' 5. Try to place a hold for Henry using the staff interface - you should get a message: Cannot place hold Too many holds: Henry Acevedo can only place a maximum of 1 total holds. 6. Apply the patch and restart everything 7. Try to place another hold using ILS-DI - you should get a - Hold 4 (Higher-order Perl): 8. You should get a this in response: <HoldTitle> <code>tooManyReserves</code> </HoldTitle> 9. Tests should pass: - prove t/db_dependent/Reserves.t - prove t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
