https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41237
Pedro Amorim <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Pedro Amorim <[email protected]> --- (In reply to Marcel de Rooy from comment #7) > Somehow this change is confusing. > Shouldnt we just check if we had a value in $params->{branchcode} instead of > looking up a patron while we could simply pass him from the script. > > If there was no value in $params->{branchcode}, you should not look for > undef. > So > - library_id => $params->{branchcode}, > This should be something like > + $params->{branchcode} ? ( library_id => > $params->{branchcode} ) : (), > > Am I missing something? Thanks for looking Marcel. I don't believe so as the correct ILLModuleCopyrightClearance AdditionalContents should be retrieved based on the patron's library, not the library selected from the form itself. What I think should happen (and is happening with this patchset): 1) Patron from library A visits the ILL request form to create a new request at: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 2) Patron is presented the ILLModuleCopyrightClearance created for their library (if any) 3) If 2 is empty, patron is presented ILLModuleCopyrightClearance created for 'All libraries' (if any) [this is where search for undef is working as intended] 4) If no ILLModuleCopyrightClearance retrieved from 2 or 3, skip it entirely and show form instead. 5) Patron is presented the form, they pick destination library B. Library B is correctly set to that ILL request's library. This is my interpretation of the issue, apologies in advance if I misunderstood your comment. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
