https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41446
Bug ID: 41446
Summary: xt/find-missing-new-lines-at-the-end-of-file.t -
doesn't check .pref files for missing new line at the
end of the file
Initiative type: ---
Sponsorship ---
status:
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Test Suite
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Bug 40541 added tests to check for files that are missing a new line at the end
of file.
It does not check the .pref files in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences
When running the qa check for bug 41427 (before the follow-up patch), it
generated a QA warning "Missing new line at the end of file, make sure your
editor correctly reads .editorconfig ('insert_final_newline = true'). See bug
40541.".
I think there are also two additional preference files that do not have a new
line at the file:
- cataloguing.pref
- interlibrary-loans.pref
The qa script generates a warning if you make changes to the files (and if, for
whatever reason, you have an editor that doesn't have insert_final_newline =
true set).
Should xt/find-missing-new-lines-at-the-end-of-file.t check .pref files as
well?
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
