https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39014

--- Comment #32 from Marcel de Rooy <[email protected]> ---
Just an observation:

members/memberentry.pl:                    push @errors,
"ERROR_guarantor_is_guarantee";                if ( $_->invalid_guarantor ) {
                    push @errors, "ERROR_guarantor_is_guarantee";
                    $template->param( guarantor_is_guarantee => $_->guarantor
);
=> Does this code not beg for renaming invalid_guarantor to something like
guarantor_is_guarantee ?

Koha/Exceptions/Patron/Relationship.pm:            } elsif (
$self->invalid_guarantor ) {
            } elsif ( $self->invalid_guarantor ) {
                $msg = sprintf("Guarantee patron cannot be a guarantor.");
=> [SAME] Does this code not beg for renaming invalid_guarantor to something
like guarantor_is_guarantee ?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to