https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41267
--- Comment #7 from Jason Robb <[email protected]> --- Thanks for working on this Nick! Part of the confusion for me is the "other hold" for the patron on the record is ignored by the "no fill" item on checkout, but not check *in*. If the intention is to only apply this rule at checkout, adding that to the column header for the setting could add clarity (i.e. Fill other holds on record at checkout). It's still a little weird that a "Don't fill my hold" item can be checked out, not fill my hold, then when I return it that exact same item will try to immediately fill my hold, but maybe there are use cases for that. The described behavior for a Lucky Day collection *can* be achieved by setting "Fill other holds on record" to "No" alongside a Hold policy of "No holds allowed" for a specific item type, which seems like an ideal setup for a browsing shelf of lucky day books. These are the steps I took for testing: 1. Create 2 items types: Fill, No fill 2. In the circ rules > holds and bookings policies for Midway: - Fill - Fill other holds on record = Yes - (Hold policy remains 'From any library' by default) - No fill - Fill other holds on record = No - (Hold policy remains 'From any library' by default) 3. Set logged in library to Midway --Hold policies follow patron home library: ReservesControlBranch - PatronLibrary (default)-- 4. Prep items - on X Power Tools (bib 6) - Set one item to the Fill/Yes itype - Set the other item to the No Fill/No itype 5. Place a record-level hold for Henry (home library is Midway by default) 6. Check out the Yes item to Henry, hold fills 7. Check in the Yes item 8. Place a record-level hold for Henry 9. Check out the No item to Henry, hold doesn't fill 10. Check in the No item, hold is triggered, confirm the hold 11. Check out the No item, hold fills --Hold policies follow item home library-- 12. Change syspref ReservesControlBranch to ItemHomeLibrary 13. Change Henry's home library to Centerville 14. Set both item home libraries to Midway 15. Place a record-level hold for Henry 16. Check out the Yes item to Henry, hold fills 17. Check in the Yes item 18. Place a record-level hold for Henry 19. Check out the No item to Henry, hold doesn't fill 20. Check in the No item, hold is triggered, confirm the hold 21. Check out the No item, hold fills --Testing for a Lucky Day use scenario-- Setup: - ReservesControlBranch = PatronLibrary - Logged in branch = Midway (mostly doesn't matter) - Henry's home library = Midway - Items' home library = Midway - Midway Fill (regular book) rule - Hold policy: From any library - Fill other holds on record: Yes - Midway No fill (lucky day book) rule - Hold policy: No holds allowed - Fill other holds on record: No 1. Place a record-level hold for Henry 2. Check out the Yes (regular book) item to Henry, hold fills 3. Check in the Yes (regular book) item 4. Place a record-level hold for Henry 5. Check out the No (lucky day book) item to Henry, hold doesn't fill 6. Check in the No (lucky day book) item, hold doesn't trigger 7. Lucky day item goes back to the lucky day shelf, Henry's hold remains until an unlucky regular item is available to fill it This seems to all be working as described, if I'm understanding the intended functionality correctly. It would definitely still help to add some clarity about the setting, though. Maybe another bullet point in the Important list that says the feature only applies at checkout and only to record-level holds? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
