https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28846
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Text to go in the| |This fixes creating release notes| |suggestions in the staff | |interface when there is no | |Koha to MARC mapping for | |`biblioitems.itemtype` | |(Koha administration > | |Catalog > Koha to MARC | |mapping). | | | |If there was no mapping, | |and you created a new | |suggestion (Acquisitions > | |Acquisitions home > | |Suggestions > New | |suggestion) you would get | |an error ("Tag "" is not a | |valid tag...."), regardless | |of whether you selected a | |value for the `Document | |type` field or not. | | | |Now: | |- If there is no mapping, | |the `Document type` field | |is no longer shown on the | |suggestion form. | |- If there is a mapping, | |the `Document type` field | |is shown on the suggestion | |form and works as expected. --- Comment #5 from David Nind <[email protected]> --- I only tested in a MARC21 installation. Is testing in a UNIMARC installation required as well? Testing notes (using KTD): 1. Step 1: 1.1 Go to Administration > Catalog > Koha to MARC mapping 1.2 Find the biblioitems.itemtype mapping 1.3 Click "Remove" 1.4 Run these scripts: . misc/batchRebuildBiblioTables.pl -c . misc/batchRebuildItemsTables.pl -c 2. Step 2: Create a suggestion: 2.1 Acquisitions > Acquisitions home > Suggestions > New suggestion 2.2 Enter details for a suggestion 2.3 Choose a value for "Document type" field 2.4 You get an error trace: Tag "" is not a valid tag. at /kohadevbox/koha/C4/Suggestions.pm line 448. at /usr/lib/x86_64-linux-gnu/perl-base/Carp.pm line 289 2.5 Repeat adding a new suggestion, without selecting anything for the "Document type" field 2.6 You get the same error as in 2.4 3. Step 5: 3.1 Reset everything in KTD so that the mapping is back: reset_all 3.2 Test again with creating a suggestion, one with something in "Document type" and one with nothing selected 3.3 Suggestions successfully created. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
