http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697
--- Comment #5 from Katrin Fischer <[email protected]> --- Created attachment 20165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20165&action=edit Bug 10697: Revert from using GetReserveStatus to use CheckReserves Patch reverts switch from CheckReserves to GetReserveStatus done by 9367 in various places. Note: You will need the patches from bug 10663 to check renewal related functionality. Note: When the check is only done for "Waiting" it will work the same before and after applying this patch as this part of GetReserveStatus works fine. In order to test this, create item and title level holds on some records, make sure that there are holds not yet pulled and items waiting for pickup in the library. Search.pm - searchResult XSLT.pm - buildKohaItemsNamespace Check item status in search result list are shown correctly using XSLT and non-XSLT views. Only checked for 'Waiting', so verify no regressions. opac-detail.pl Check on item status is shown correctly on detail pages in OPAC. if( $reserve_status eq "Reserved"){ $itm->{'onhold'} = 1; } seems to be not used, verify no regressions. circulation.pl - build_issue_data opac-user.pl Check items on hold are properly marked in the list of checkouts and can not be renewed for - patron account pages in the staff interface - patron account pages in the OPAC $it->{'renew_error'} = ( $restype eq "Waiting" or $restype eq "Reserved" ) ? 1 : 0; seems to be not used, verify no regressions. Run unit tests from first patch and any additional tests you can think of. Signed-off-by: Katrin Fischer <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
