https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41315
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from David Nind <[email protected]> --- I attempted to test, but I don't think I'm seeing what I should see. Happy to test again if you can point out where I may have gone wrong. Before the patch ================= 1. I issued three items at Centerville to patrons from three different libraries in the same patron category - I selected the day before 'Yesterday' for the due date when checking out. 2. The Barcodes for items checked out (all the items are from Centerville): - 39999000001570 - 39999000008975 - 39999000001617 3. The output from the SQL query: MariaDB [koha_kohadev]> SELECT borrowers.cardnumber, borrowers.surname, borrowers.branchcode, borrowers.categorycode, issues.issue_id, issues.branchcode, issues.date_due FROM issues JOIN borrowers USING (borrowernumber); +----------------+---------+------------+--------------+----------+------------+---------------------+ | cardnumber | surname | branchcode | categorycode | issue_id | branchcode | date_due | +----------------+---------+------------+--------------+----------+------------+---------------------+ | 23529000651225 | Burton | MPL | PT | 1 | CPL | 2025-12-24 23:59:00 | | 23529000065863 | Hawkins | SPL | PT | 2 | CPL | 2025-12-24 23:59:00 | | 23529000065863 | Hawkins | SPL | PT | 3 | CPL | 2025-12-24 23:59:00 | +----------------+---------+------------+--------------+----------+------------+---------------------+ 3 rows in set (0.001 sec) 4. For the overdue notice/status triggers: - Select library: Default - Patron category - Patron: . Delay: 1 . Letter: Overdue notice (ODUE) - Nothing else entered 5. Steps 5 and 6: - Output for step 5 - Each pass shows as CPL for me. - Is this right/what is expected? - Step 6 says I should see different branches - in the description for the bug, the output has different library codes for each pass -- pass 1 = CPL, pass 2 = FFL, and pass 3 = FFL: perl misc/cronjobs/overdue_notices.pl --triggered --library CPL --test --nomail -v -v Found 12 branches with first message enabled: 'CPL', 'FFL', 'FPL', 'FRL', 'IPT', 'LPL', 'MPL', 'PVL', 'RPL', 'SPL', 'TPL', 'UPL' branch CPL passed on parameter branch CPL have overdue rules ====================================== branchcode : 'CPL' using root@localhost branch 'CPL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber CPL | PT (1, 90, 2025-12-26T01:10:19) -------------------------- Found 3 borrowers with overdues branch 'CPL', categorycode = PT pass 2 No letter code found for pass 2 branch 'CPL', categorycode = PT pass 3 No letter code found for pass 3 After the patch =============== Output from step 5 - no change ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ perl misc/cronjobs/overdue_notices.pl --triggered --library CPL --test --nomail -v -v Found 12 branches with first message enabled: 'CPL', 'FFL', 'FPL', 'FRL', 'IPT', 'LPL', 'MPL', 'PVL', 'RPL', 'SPL', 'TPL', 'UPL' branch CPL passed on parameter branch CPL have overdue rules ====================================== branchcode : 'CPL' using root@localhost branch 'CPL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber CPL | PT (1, 90, 2025-12-26T01:15:25) -------------------------- Found 3 borrowers with overdues branch 'CPL', categorycode = PT pass 2 No letter code found for pass 2 branch 'CPL', categorycode = PT pass 3 No letter code found for pass 3 Steps 9 and 11 ~~~~~~~~~~~~~~ I'm not sure what is meant by "Confirm branch is consistent". Should it be CPL for each pass? From the output above, it is the same as before the patch - all showing CPL for for each pass. Output from step 10 - I removed '--libary CPL' from the command (is that correct?) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ perl misc/cronjobs/overdue_notices.pl --triggered --test --nomail -v -v Found 12 branches with first message enabled: 'CPL', 'FFL', 'FPL', 'FRL', 'IPT', 'LPL', 'MPL', 'PVL', 'RPL', 'SPL', 'TPL', 'UPL' ====================================== branchcode : 'CPL' using root@localhost branch 'CPL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber CPL | PT (1, 90, 2025-12-26T01:18:23) -------------------------- Found 3 borrowers with overdues branch 'CPL', categorycode = PT pass 2 No letter code found for pass 2 branch 'CPL', categorycode = PT pass 3 No letter code found for pass 3 ====================================== branchcode : 'FFL' using root@localhost branch 'FFL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber FFL | PT (1, 90, 2025-12-26T01:18:23) -------------------------- Found 0 borrowers with overdues branch 'FFL', categorycode = PT pass 2 No letter code found for pass 2 branch 'FFL', categorycode = PT pass 3 No letter code found for pass 3 ====================================== branchcode : 'FPL' using root@localhost branch 'FPL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber FPL | PT (1, 90, 2025-12-26T01:18:23) -------------------------- Found 0 borrowers with overdues branch 'FPL', categorycode = PT pass 2 No letter code found for pass 2 branch 'FPL', categorycode = PT pass 3 No letter code found for pass 3 ====================================== branchcode : 'FRL' using root@localhost branch 'FRL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber FRL | PT (1, 90, 2025-12-26T01:18:23) -------------------------- Found 0 borrowers with overdues branch 'FRL', categorycode = PT pass 2 No letter code found for pass 2 branch 'FRL', categorycode = PT pass 3 No letter code found for pass 3 ====================================== branchcode : 'IPT' using root@localhost branch 'IPT', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber IPT | PT (1, 90, 2025-12-26T01:18:23) -------------------------- Found 0 borrowers with overdues branch 'IPT', categorycode = PT pass 2 No letter code found for pass 2 branch 'IPT', categorycode = PT pass 3 No letter code found for pass 3 ====================================== branchcode : 'LPL' using root@localhost branch 'LPL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber LPL | PT (1, 90, 2025-12-26T01:18:23) -------------------------- Found 0 borrowers with overdues branch 'LPL', categorycode = PT pass 2 No letter code found for pass 2 branch 'LPL', categorycode = PT pass 3 No letter code found for pass 3 ====================================== branchcode : 'MPL' using root@localhost branch 'MPL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber MPL | PT (1, 90, 2025-12-26T01:18:23) -------------------------- Found 0 borrowers with overdues branch 'MPL', categorycode = PT pass 2 No letter code found for pass 2 branch 'MPL', categorycode = PT pass 3 No letter code found for pass 3 ====================================== branchcode : 'PVL' using root@localhost branch 'PVL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber PVL | PT (1, 90, 2025-12-26T01:18:23) -------------------------- Found 0 borrowers with overdues branch 'PVL', categorycode = PT pass 2 No letter code found for pass 2 branch 'PVL', categorycode = PT pass 3 No letter code found for pass 3 ====================================== branchcode : 'RPL' using root@localhost branch 'RPL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber RPL | PT (1, 90, 2025-12-26T01:18:23) -------------------------- Found 0 borrowers with overdues branch 'RPL', categorycode = PT pass 2 No letter code found for pass 2 branch 'RPL', categorycode = PT pass 3 No letter code found for pass 3 ====================================== branchcode : 'SPL' using root@localhost branch 'SPL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber SPL | PT (1, 90, 2025-12-26T01:18:23) -------------------------- Found 0 borrowers with overdues branch 'SPL', categorycode = PT pass 2 No letter code found for pass 2 branch 'SPL', categorycode = PT pass 3 No letter code found for pass 3 ====================================== branchcode : 'TPL' using root@localhost branch 'TPL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber TPL | PT (1, 90, 2025-12-26T01:18:23) -------------------------- Found 0 borrowers with overdues branch 'TPL', categorycode = PT pass 2 No letter code found for pass 2 branch 'TPL', categorycode = PT pass 3 No letter code found for pass 3 ====================================== branchcode : 'UPL' using root@localhost branch 'UPL', categorycode = PT pass 1 Using letter code 'ODUE' for pass 1 --------Borrower SQL------ SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, date_due FROM issues,borrowers,categories,items WHERE issues.borrowernumber=borrowers.borrowernumber AND borrowers.categorycode=categories.categorycode AND issues.itemnumber = items.itemnumber AND items.itemlost = 0 AND TO_DAYS(NOW())-TO_DAYS(issues.date_due) >= 0 AND issues.branchcode=? AND borrowers.categorycode=? AND categories.overduenoticerequired=1 ORDER BY issues.borrowernumber UPL | PT (1, 90, 2025-12-26T01:18:23) -------------------------- Found 0 borrowers with overdues branch 'UPL', categorycode = PT pass 2 No letter code found for pass 2 branch 'UPL', categorycode = PT pass 3 No letter code found for pass 3 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
