https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37512

--- Comment #32 from Baptiste Wojtkowski (bwoj) 
<[email protected]> ---
(In reply to Owen Leonard from comment #29)
> In my test I ran into two problems:
> 
> 1. Once I have triggered the lock, clicking the link to reset the account
> renews the patron as if I had clicked the "Renew" link on an expired patron
> account. I see the message about the account being renewed, and the
> expiration date is updated. The lock is also removed.
> 
> 2. I tried it using both card number and username for login, and I found
> that I could try logging in with card number and incorrect password many
> times, over the FailedLoginAttempts limit, without getting a message that
> the account was locked. As soon as I tried the username with an incorrect
> password I got the lock message. As far as I can tell the failed login
> attempts with the card number are triggering the lock, but the login page
> doesn't show the error message about the lock.

I do not understand the second point. AFAIK, the concerned code is not part of
the patch and is not supposed to provide the reason why you have been blocked. 

In opac-auth.tt:
 75                             [% IF invalid_username_or_password ||
too_many_login_attempts %]
 76                                 <!-- This is what is displayed if user
doesn't have permission or account is lock    ed. (Do not expose more
information than needed.) -->
 77                                 <div class="alert alert-info">
 78                                     <p aria-live="assertive" role="alert"
 79                                         >You entered an incorrect username
or password. Please try again! But not    e that passwords are case sensitive.
 80                                         [% IF
Koha.Preference('FailedLoginAttempts') %]
 81                                             Your account will be locked
after a fixed number of failed login atte    mpts.
 82                                         [% END %]
 83                                         Please contact a library staff
member if you continue to have problems.</    p
 84                                     >
 85                                 </div>
 86                             [% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to