https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27115
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue when release notes| |stopping and restarting SIP | |servers using `koha-sip` - | |it would sometimes not | |restart the SIP servers. | | | |This was because a restart | |could attempt the --start | |command while a previous | |SIP server was still | |running. This could result | |in the SIP server not | |restarting at all. | | | |The fix replaces `daemon | |--stop` with | |`start-stop-daemon --stop` | |in the code, to ensure that | |all the running SIP servers | |are actually stopped before | |restarting. CC| |[email protected] --- Comment #7 from David Nind <[email protected]> --- I think I tested this correctly, and that I observed the expected results! In KTD, the SIP server is already running, but I went through the process of stopping it and then disabling it before working through the test plan. I've attempted a release note. Testing notes (using KTD): 1. SIP is already running in KTD for kohadev: sudo koha-sip --verbose --status kohadev SIP server running for kohadev:. 2. Make the change in step 3 of the test plan - made min_servers = 6: vi /etc/koha/sites/kohadev/SIPconfig.xml 3. Stop the SIP server: sudo koha-sip --verbose --stop kohadev Stopping SIP server for kohadev:. 4. Disable the SIP server: sudo koha-sip --verbose --disable kohadev Stopping running SIP Warning: SIP server not running for kohadev:. Information: SIP server disabled for kohadev 5. Check that no SIP servers are running: ps aux | grep kohadev-koha-sip kohadev+ 17009 0.0 0.0 9008 2176 pts/0 S+ 18:07 0:00 grep kohadev-koha-sip sudo koha-sip --verbose --status kohadev SIP server not running for kohadev: failed! 6. Enable the SIP server: sudo koha-sip --verbose --enable kohadev Enabling SIP server for kohadev - edit /etc/koha/sites/kohadev/SIPconfig.xml to configure 7. Start the SIP server: sudo koha-sip --verbose --start kohadev Starting SIP server for kohadev:. 8. Check the number of servers running - this is 7 for me (min_servers = 6): ps aux | grep $SIPINSTANCE-koha-sip kohadev+ 17366 0.0 0.0 8176 1808 ? S 18:12 0:00 daemon --name=kohadev-koha-sip --errlog=/var/log/koha/kohadev/sip-error.log --output=/var/log/koha/kohadev/sip-output.log --verbose=1 --respawn --delay=30 --pidfiles=/var/run/koha/kohadev --user=kohadev-koha.kohadev-koha -- perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17368 0.8 0.6 308364 208892 ? S 18:12 0:01 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17373 0.0 0.5 308364 187492 ? S 18:12 0:00 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17374 0.0 0.5 308364 187492 ? S 18:12 0:00 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17375 0.0 0.5 308364 187492 ? S 18:12 0:00 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17376 0.0 0.5 308364 187492 ? S 18:12 0:00 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17377 0.0 0.5 308364 187492 ? S 18:12 0:00 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17378 0.0 0.5 308364 187492 ? S 18:12 0:00 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17517 0.0 0.0 9008 2304 pts/0 S+ 18:14 0:00 grep kohadev-koha-sip 9. Back to step 7 of the test plan: sudo koha-sip --verbose --stop kohadev; ps aux | grep kohadev-koha-sip Stopping SIP server for kohadev:. kohadev+ 17366 0.0 0.0 8176 1808 ? S 18:12 0:00 daemon --name=kohadev-koha-sip --errlog=/var/log/koha/kohadev/sip-error.log --output=/var/log/koha/kohadev/sip-output.log --verbose=1 --respawn --delay=30 --pidfiles=/var/run/koha/kohadev --user=kohadev-koha.kohadev-koha -- perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17368 0.4 0.6 308364 208892 ? R 18:12 0:01 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17373 0.0 0.5 308364 188900 ? R 18:12 0:00 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17374 0.0 0.5 308364 188900 ? R 18:12 0:00 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17375 0.0 0.5 308364 188900 ? R 18:12 0:00 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17376 0.0 0.5 308364 188900 ? R 18:12 0:00 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17377 0.0 0.5 308364 188900 ? R 18:12 0:00 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17378 0.0 0.5 308364 188900 ? R 18:12 0:00 kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml kohadev+ 17666 0.0 0.0 9008 2048 pts/0 S+ 18:16 0:00 grep kohadev-koha-sip 10. Step 10 of the test plan - start the SIP server (7 running after this): sudo koha-sip --verbose --start kohadev Starting SIP server for kohadev:. 11. After applying the patch - end result is 7 SIP servers running (from e ps aux command): reset_all + step 2 above + restart_all 12. Steps 12 to 14 of the test plan: sudo koha-sip --verbose --stop kohadev; ps aux | grep kohadev-koha-sip Stopping SIP server for kohadev:. kohadev+ 20224 0.0 0.0 9008 2048 pts/0 S+ 18:28 0:00 grep kohadev-koha-sip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
