https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38739

Victor Grousset/tuxayo <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
             Status|Signed Off                  |Passed QA

--- Comment #36 from Victor Grousset/tuxayo <[email protected]> ---
I've been going at the changed pages and doing a diff before and after the
patches on
- the final HTML in the inspector (after eventual JS does it's stuff, but the
browser will fix some stuff like stray tags)
- the HTTP response

And also comparing the HTMLs results the W3C validator.

The changes are great, in hold-group.tt, on main, the cookieConsentBar was
duplicated :o In the final html in the inspector, it is also present in the
holds group modal.
It was invisible but still, it was there and duplicated. So now it's fixed.

audio-alert was also duplicated.

Overall on the pages, several unclosed <div> are fixed. I think also some other
tags that were stray.


Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to