https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39584
--- Comment #20 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 190825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190825&action=edit Bug 39584: Fix trail period incorrectly limiting max booking date This commit fixes a bug where the trail period was preventing selection of the maximum end date allowed by circulation rules, even when there were no booking conflicts in the trail period. The Problem: ============ The hover logic in place_booking.js checked if ANY disabled date fell within the trail period and would prevent selection. However, dates can be disabled for multiple reasons: 1. They conflict with an existing booking (correct reason to disable) 2. They are beyond the maxDate set by circulation rules (incorrect!) 3. They are in the past When hovering over the max selectable end date, the trail period would extend beyond the maxDate. Those dates were disabled by flatpickr automatically, and the code incorrectly interpreted this as a booking conflict, preventing selection of the otherwise valid max date. The Fix: ======== Modified the trail period conflict check (lines 995-1005) to only consider dates that are within the max date range. Disabled dates beyond the maxDate are now ignored when checking for trail conflicts. Before: if (elemDate.isAfter(trailStart) && elemDate.isSameOrBefore(trailEnd)) { trailDisable = true; } After: if (elemDate.isAfter(trailStart) && elemDate.isSameOrBefore(trailEnd)) { const maxDate = periodPicker.config.maxDate ? dayjs(periodPicker.config.maxDate) : null; if (!maxDate || elemDate.isSameOrBefore(maxDate)) { trailDisable = true; } } This ensures trail periods only prevent selection when they conflict with actual bookings, not when they extend beyond the circulation rules' maximum date. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
