https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36021

--- Comment #11 from David Cook <[email protected]> ---
(In reply to mteal from comment #10)
> It looks like the original intent of this bug was written up regarding a
> patron signed up for automatic renewal, but the "Scheduled for automatic
> renewal" shows up for items checked out are not eligible for renewal. 
> Should the issue that "Scheduled for automatic renewal" shows up for patrons
> who have opted out of automatic renewals be a separate bug? It doesn't seem
> like this part would be as complicated to address as the original issue.

That's a good question... I think you're probably right.

Looking at the OP... yeah I suppose that is a different issue. We do have the
output of CanBookBeRenewed at hand in svc/checkouts, but we'd need to
interrogate it and do lots of if/elsif/elses I think. It would probably be a
bit of work but it might be worthwhile to do...

--

Looking at "svc/checkouts", it looks like it just reports "auto_renew" enabled
if auto_renew is enabled for the checkout.

That endpoint should probably also show borrowers.autorenew_checkouts, and then
only show "Scheduled for automatic renewal" in
koha-tmpl/intranet-tmpl/prog/js/checkouts.js if both oObj.auto_renew and
oObj.patron_auto_renew are true. 

Since I think ./misc/cronjobs/automatic_renewals.pl only selects checkouts
where both the item has auto_renew and the borrower has autorenew_checkouts...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to