https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37707
Andrew Fuerste-Henry <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Andrew Fuerste-Henry <[email protected]> --- (In reply to Martin Renvoize (ashimema) from comment #9) > Created attachment 190862 [details] [review] > Bug 37707: (follow-up) Add textual feedback for booking lead/trail period > conflicts This seems to be enforcing allowable dates correctly, but the messaging doesn't match what's given in the test plan and is not entirely accurate. Additionally, some messages use "lead period" and "trail period" which other use "preparation time" and "processing period." We should use "lead period" and "trail period" consistently. > 5. Hover over Jan 12 (part of existing booking) > - Verify message: "This date is part of an existing booking" Message I receive here is "Cannot select: Lead period (2 days before start) conflicts with existing booking." This is accurate in that the whole of the lead period for the new booking would be within the date range of the existing booking. But the test plan says I should just get told that the date I'm trying to select is within an existing booking and that would be a simpler message. > 6. Hover over Jan 8 (existing booking's lead period) > - Verify message explains it's part of the lead period Message I receive here is "Cannot select: Processing period (3 days after return) conflicts with existing booking's preparation time." This is potentially accurate -- if I'm trying to make a booking that starts on 1/8 and ends on 1/9, then the trail period of the new booking would include 1/9, which is in the lead period for my existing booking. But it would be more clear and true to tell me I can't start a booking on 1/8 because 1/8 is within the lead time for the existing booking. > 7. Try to select Jan 19-20 as booking dates (2-day lead = Jan 17-18) > - Hover over Jan 19 when it appears disabled > - Verify error message: "conflicts with existing booking's trail period" Hovering over 1/19 or 1/20, I get the message "Cannot select: Lead period (2 days before start) conflicts with existing booking." This is inaccurate. I should be told the new lead period would conflict with the existing trail period. Hovering over 1/16, 1/17, or 1/18, I get the message "Cannot select: Lead period (2 days before start) conflicts with existing item's processing time." This is inaccurate for 1/16; the lead time for a booking starting 1/16 would be fully within the existing booking rather than in its trail period. > 8. Hover over Jan 21 (no conflicts) > - Verify info message about lead/trail requirements These messages get confusing if I edit my circ rules so that I'm only setting a lead time *or* a trail time. If I put a 2 in "Booking pre-processing" and leave "Booking post-processing" blank, the circ rules interface actually saves a blank booking_trail_period value and then the message when placing a booking reads "Selecting end date. Processing period: days after return" It should either not mention lead periods or trail periods at all if the given value is blank. In fact, it should probably not mention them for values of 0, either. Additionally, if I have a lead period of 2 days defined and try to place a booking starting fewer than 2 days in the future, I get the message "Cannot select: Lead period (2 days before start) conflicts with existing booking." I get this message even on a record with no existing bookings at all. If I'm trying to select a date in the past, it should tell me I cannot select a date in the past. If I'm trying to select a date that would put my lead period in the past, it should tell me that the date cannot be selected because it would provide insufficient lead time. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
