https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #38 from Katrin Fischer <[email protected]> --- I did some testing here: 1) Patches are not passing QA script (Problem) [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt` 2) Schema changes (Note) Something is odd with the attached schema patch as it removes all documentation comments from the schema files and therefore contains many more changes than necessary. As it's not going to be pushed, just noting. 3) Spelling (Suggestion) The code and db use sub_location, but the description for the GUI is sublocation. Should we make them match to make things less confusing down the road? I know we have a lot of these inconsistencies in Koha, but as we are starting out fresh here it might make sense to avoid one more :) description: sub_location for this item + `sub_location` varchar(80) DEFAULT NULL COMMENT 'authorized value for the sublocation for this item', <span class="label">Sublocation:</span> 4) Frameworks und Koha to MARC mappings (OK) This doesn't contain a change to the frameworks or mappings. For existing installations I believe this is OK, as we only have one lower case subfield (k) left and we cannot assume that libraries have not been using any lower or upper case letters in their configurations already. The downside is, that this means the feature won't be active by default in a new installation, so we might want to think about some extra good documentation. I found one oddity while testing: In order for things to work nicely, you have to add the subfield definition to the DEFAULT framework. If you don't, you will have display problems on all pages (sublocation not showing at all or only showing as code). I initially had only added it to the BKS framework and all problems in testing resolved, once it was added to Default as well. This could be something to note in the release notes maybe or in any instructions for setting this up. 5) Authorised value category (Suggestion) It could be a good idea to add an empty authorised value category in the installer files and the database update. It would not 'hurt' and might help to advertise the feature. 6) Testing a) Staff interface - item editor (OK) b) Staff interface - detail page, holdings table (OK) c) Staff interface - detail page, items tab (OK) d) List of checkins (Problem) The sublocation displays, but the location is gone. I believe this could be due to the missing item_ here: - <span class="shelvingloc">[% checkin.item_location | html %]</span> + <span class="shelvingloc">[% checkin.location | html %] [% IF ( checkin.sub_location ) %] ([% checkin.sub_location | html %]) d) Questions * Why is the field not added to the OPAC as well? * Why is it added to the list of returns, but not to the list of checkouts? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
