https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37707
Andrew Fuerste-Henry <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Andrew Fuerste-Henry <[email protected]> --- Following the test plan in comment 15, I've run into some issues. I've got a bib with just 1 item on it. That item is bookable. After creating a booking for January 10-15, the calendar to create a new booking has January 10-16 greyed out, as if my booking were 10-16. In the calendar, mousing over days in the past gives error messages as if all past dates are part of an existing booking. When mousing over a date to select the start of a booking, the system gives feedback about the potential booking's trail period. I would suggest we should only give feedback about the potential booking's trail period when selecting the end of the potential booking. Until the user is proposing a booking end date, we cannot know what that booking's trail will conflict with. The datepicker and message area generally appeared above the Booking Dates input field. However, sometimes the datepicker and message area appeared below the input field instead. When this happened, the bottom of the message field pushed out of my window and could not be seen without zooming my browswer out. I was not able to scroll down to see the rest of the message. The messages contain inconsistent capitalization. Errors all start "Cannot select:" but the first word following that colon is sometimes capitalized and sometimes not. (In reply to Martin Renvoize (ashimema) from comment #15) > 6. Test existing booking conflict messages: > - Hover over Jan 12 (part of existing booking) > * Verify message: "Cannot select: This date is part of an existing > booking" This gives me the message "lead period conflicts with existing booking; trail period conflicts with an existing booking." The first statement will be true if I select 1/12 as the start of my booking. The second statement will be true if I select 1/12 as the end of my booking. In either case, the proposed message of "This date is part of an existing booking" would be more clear. > - Hover over Jan 8 (existing booking's lead period) > * Verify message: "Cannot select: This date is part of an existing > booking's lead period" This gives me the message "lead period conflicts with existing booking; trail period conflicts with existing booking's lead period." The first statement is *not* true, the lead period for a booking starting 1/8 would need to start 1/6, which is in the past and does not have a booking. > - Hover over Jan 16 (existing booking's trail period) > * Verify message: "Cannot select: This date is part of an existing > booking's trail period" This gives me the message "This date is part of an exiting booking." This is *not* true, 1/16 is part of the trail period of my existing booking. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
