https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39014
--- Comment #51 from Nick Clemens (kidclamp) <[email protected]> --- (In reply to Lari Taskula from comment #49) > (In reply to Lucas Gass (lukeg) from comment #48) > > I added a patch to remove the tests in question. I'm not convinced this is > > correct. Do we want to add a warn somewhere that can be logged? For > > troubleshooting/support? > > I don't see much value in logging that, as misconfigured patron > relationships no longer stop Koha from performing circulation actions. > Having librarians alerted on the staff client is in my opinion sufficient. > Librarians are notified of invalid patron relationships on the patron's > "Check out" and "Details" tab, thanks to Bug 39180. As for the check-in > screen, I suppose we have lost that ability. > > (out of scope) It would also be useful to have a report that lists all the > patrons with an invalid patron relationship/alerts them on the staff main > page. In the new catch, we specifically handle two types of exceptions, but we don't have an else case, so if another exception is thrown, it's just going to be ignored. I kind of think if we're throwing an exception, we should always log it. The librarian may see the alert, and then dismiss it, without resolving the problem, having it in the logs ensures it can be found later. I would actually lean towards making all exceptions log, every time - if we think it warrants an exception, I think it warrants logging -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
