https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795
Pedro Amorim <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Pedro Amorim <[email protected]> --- > 7. Navigate to "Make a payment" Observe both columns have a text box that's > immediately editable. The note should be filled on the charge with a note. This doesn't happen for me (before applying patches). The entry without a note does not have a text box. It instead has a '+ Add note' link. > 8. Apply the patch > 9. Repeat step 5, observe the column with no note says "Add" now. > 10. Repeat step 7, observe the payment note field matches the "note" field > on transactions. > 11. Edit the existing note and save When I edited the existing note it caused it to be deleted (on the "Make a payment" tab) > 12. Add a new note for the other transaction and save. Adding a new note doesn't work (on the "Make a payment" tab) The following change is required in members/pay.pl to fix the issues above: - my $note = scalar $input->param('edited_note'); + my $note = scalar $input->param('payment_note'); Suggestion: If cud-edit_note in pay.pl is a copy paste of the same cud-edit_note in boraccount.pl then this code should be moved to a new method in Koha::Account::Line called update_note (or similar?) and have both cud-edit_note logics invoke it. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
