https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Katrin Fischer <[email protected]> --- Testing... overall this works as expected. Mostly some smaller issues with the database update. If you follow-up I will try to come back to this ASAP for SO. 1) QA checks pass. (OK) 2) Code review a) Database update (blocker) * Schema changes should be in a separate patch file. * This activates the new options by default on update. I am not sure if this is what we want here or not. Raising as a question. But if we really want to do this: Results could be inconsistent depending on which options have been activated for Pseudonymization. If we wanted to do this maybe check for pref not empty and then concatenate the new options at the end? Given, transaction_type is probably always activated, but sex might be not. * The database update is missing a success message. Have a look at the latest database updates or the skeleton file. b) Terminology (no blocker) * + `operator` int(11) DEFAULT NULL COMMENT 'User id (if user has extra permissions, operator, api-keys user, sip-user, librarian)', + operator: "Operator ID (user id if it has extra permissions, i.e. librarian)" Should user id be user ID or even borrowernumber here? 3) Testing (OK) Followed the test plan and this works as expected. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
