https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40777
Victor Grousset/tuxayo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #47 from Victor Grousset/tuxayo <[email protected]> --- > the tests are not supposed to pass with UNIMARC No worries about the tests then. I looked at the failure and it seems it's the test code that somehow puts a @. The business code gets it back so it does it's job even in UNIMARC. > Re TYPEDOC and LIVR the behavior with this patch should be the same as > before. Do you see a change in the behavior or was it the same on main? From what I understand from above, I got the audit to pass even though my record 099$t value doesn't exist in itemtypes table. I can't compare vs main, it's the new audit. Wait! it's not new, it's originally from search_for_data_inconsistencies.pl Ok it's not from this patch. search_for_data_inconsistencies.pl can also be fooled. Including in MARC21 if I just change in the framework the authorized values from itemtypes to TYPEDOC (or any auth value category) which have not any values in MARC21 sample data. Having the same bugs is actually a good sign the extraction of business logic didn't mess things up ^^ at least in the scope of my whack tests. ---- Thanks David for the test plan :) ---- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
