https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955
--- Comment #19 from David Cook <[email protected]> --- This code is a bit nauseating to look at 😅. There's so many different permutations of holds rules... and any change will break one of these tests: t/db_dependent/Koha/Holds.t t/db_dependent/Holds.t t/db_dependent/Circulation.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Reserves.t I don't think that I know holds/reserves well enough to try to fiddle with the business logic. -- Maybe when placing the hold, we have to capture that it has an override attached to it, and then in CheckReserves if there's an override we ignore all the policy stuff. That could be a way where we honour the existing business logic while also trying to honour the override... Both item-specific and bib-level holds could contain the override in their reserve... so that could work for both. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
