https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663

Tomás Cohen Arazi (tcohen) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|24.11                       |Main
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
Lucas, a couple issues:

(1) Why don't you just

```sql
UPDATE systempreferences
SET value=0
WHERE type='YesNo' AND value='';
```

that would cover some other cases as well (i.e. people coming from versions
older than 24.11)

(2) You commit message should include a concrete test plan. In my opinion your
first message here contains half of the test plan, so you would need to add a
step that tells the tester to start over, but when switching to main, apply
this patch first or similar.

Thanks for taking care of this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to