https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328
--- Comment #26 from Emmi Takkinen <[email protected]> --- (In reply to Owen Leonard from comment #25) > Some complaints from the qa tools: > > [FAIL] C4/Barcodes/ValueBuilder.pm > SKIP pod_coverage > No POD exists > FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > C4/Barcodes/ValueBuilder.pm` > [FAIL] C4/Barcodes/preyymmddts.pm > FAIL forbidden_patterns > forbidden pattern: Use https:// instead of http:// for URLs > (line 18) > SKIP pod_coverage > No POD exists > FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > C4/Barcodes/preyymmddts.pm` Hmm, I used the new perl-qa-tools and got sligthly different report from it: Result: [PASS] C4/Barcodes.pm SKIP spelling [SKIP] C4/Barcodes/ValueBuilder.pm SKIP pod_coverage No POD exists SKIP spelling [SKIP] C4/Barcodes/preyymmddts.pm SKIP pod_coverage No POD exists SKIP spelling [FAIL] cataloguing/additem.pl SKIP spelling FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl cataloguing/additem.pl` [FAIL] cataloguing/value_builder/barcode.pl SKIP spelling FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl cataloguing/value_builder/barcode.pl` [FAIL] cataloguing/value_builder/barcode_manual.pl SKIP spelling FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl cataloguing/value_builder/barcode_manual.pl` [PASS] installer/data/mysql/atomicupdate/bug_30328.pl SKIP spelling [PASS] installer/data/mysql/mandatory/sysprefs.sql [PASS] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref [PASS] t/Barcodes_preyymmddts.t SKIP spelling [PASS] t/db_dependent/Barcodes_ValueBuilder.t SKIP spelling Processing additional checks PASS! * Have you considered sharing the new syspref to HEA? (see bug 23849 and C4/UsageStats.pm) Running tests (2) * Proving /home/emmi/Koha/t/Barcodes_preyymmddts.t PASS * Proving /home/emmi/Koha/t/db_dependent/Barcodes_ValueBuilder.t PASS Tidiness issues all come from package imports, tool suggests that there should only be a single space between package name and qw so that this use Encode qw( encode_utf8 ); use List::MoreUtils qw( any uniq ); becomes this use Encode qw( encode_utf8 ); use List::MoreUtils qw( any uniq ); But lining the qw's seems to be intentional (see e.g. Bug 36498 tidy commit), so maybe those can be ignored? Also new qa-tool doesn't report any issues in C4/Barcodes/ValueBuilder.pm and misses the forbidden pattern in URL. I'll try to run this through old qa-tool to see if ValueBuilder.pm has any other issues than package imports. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
