https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387
Nick Clemens (kidclamp) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #130 from Nick Clemens (kidclamp) <[email protected]> --- Overall, this is very slick, and very constrained to its own area, so I think it's a good addition. Couple things I noticed: Must fix: - the new permission should explicitly state that it is both bibliographic records and items - date filtering appears to be on timestamp - it should use deleted_on which is what displays - you added: CAN_user_editcatalogue_edit_catalogue as a condition to display the cataloging module link - so a user with only edit catalogue now gets a blank cataloging page, looks like a leftover from before the permission was added - I think the restoration/deletion needs to be in a transaction to prevent a case where something is restored and not removed from the old table? Should fix: - new permission is under tools, not cataloging the test plan and the commit are wrong - When trying to restore a deleted item from a deleted bib, I would expect restoring the bib would also restore the item I clicked initiially - feels like extra work to have to then click item I would expect the biblio modal to display the items with the previous item preselected - Better error handling: Try 1 - delete an item 2 - add new item to catalog with same barcode 3 - try to restore old item 4 - only failure is reported Error restoring item 2021: Something went wrong, check Koha logs for details. It seems this should give some indication Could fix: I added 1000 items to a record, deleted them all. The biblio list displayed very fast, this was nice to see, however only showing the library codes is a little messy, this might impact speed, but not everyone knows their branch codes. The choice of columns overall seems a little arbitrary - none of the notes/collection/etc. - I suppose the assumption is I have the item to use the barcode? Similarly - if I delete an item and not a bib I have to know the biblionumber to find it in the list - not being able to search by title is odd but makes sense if you assume item is in hand -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
