https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721
Matt Blenkinsop <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191657|0 |1 is obsolete| | --- Comment #28 from Matt Blenkinsop <[email protected]> --- Created attachment 191910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191910&action=edit Bug 39721: Changes suggestion_ref in order to remove it suggestion_ref is quite messy, it needs to be reworked in order to use objects in suggestion.pl. As far as I studied, it is used as - the whole input from forms, - the default content to input in a form - the content that will be amended in order to propose another hash to modSuggestion. However, ModSuggestion will be removed so we don't need such a hash - every suggestion that need to be updated using the "change selected suggestion" tool - create the object suggestion_only, whose purpose is still unclear to me. As a result it is created by : > 25 my $suggestion_ref = { $input->Vars }; And by removing a number of keys depending on the use of suggestion_ref in the script. In this patch, we remove every code made to use suggestion_ref as the source object for form and use another variable, $stored_suggestion which is an object. In next patch we aim at fully removing $suggestion_ref, which is still used by ModSuggestion Signed-off-by: Matt Blenkinsop <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
