https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41315
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|[email protected] |[email protected] |y.org | CC| |[email protected] --- Comment #14 from Marcel de Rooy <[email protected]> --- Passing QA. Having the impression that the changes around patron-homebranch did not make this code easier to maintain etc.. Just a minor observation. This looks dubious (L516): if ($owning_library) { $item_sql .= ' AND items.homebranch = ? ' unless ($patron_homelibrary); If you set item-homebranch, why test if it is patron-homebranch ? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
