https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds the option to release notes| |send a notification to the | |patron when a recall is | |canceled by staff or via | |the OPAC. If a patron | |receives the notification | |can be set up through the | |messaging preferences in | |the patron account. | |This uses the new notice | |template | |`RECALL_MANUAL_CANCEL`. Summary|Send a notification when a |Send a notification when a |recall is manually |recall is manually canceled |cancelled | --- Comment #41 from Katrin Fischer <[email protected]> --- Hi Aleisha, full report below, but good call with the re-testing! Fixed in follow-up. Problem was caused by bug 29194. (In reply to Aleisha Amohia from comment #33) > (In reply to David Nind from comment #29) > > The patches no longer apply 8-(... When that is fixed, I think the status > > can change to signed off. > > > I think I let too much time before coming back to rebase unfortunately. This > should get re-tested please! I found some issues that were mostly caused by changes since this was written. Would you mind reviewing the follow-ups and maybe signing them off? 1) QA checks - PASS! (fails with follow-up for the merging of the database update files, but I think this is OK here) 2) Code review a) Atomic updates could be merged into one file and are missing "success" messages. I'll provide a follow-up patch for this. b) Cancelled should be canceled. I stumbled over this as it was just a topic in the last development meeting. As we have in our coding guidelines to use AE, it should read canceled. https://wiki.koha-community.org/wiki/Terminology#C Example from patches: Recall has been cancelled We regret to inform you that the item you have recalled cannot be provided. Your recall was cancelled. Provided a second follow-up patch for this. 3) Testing a) Notice was not showing up in messaging preferences Fixed in follow-up. Problem was caused by message_transport_id mismatch (14 -> 15). b) Notice showed at the bottom of the list instead of with other recall notices -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
