https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds a new |This enhancement adds a new release notes|system preference |system preference |AllowRenewalIfOtherItemsAva |`AllowRenewalIfOtherItemsAv |ilableLocation which works |ailableLocation` which |in conjunction with the |works in conjunction with |AllowRenewalIfOtherItemsAva |the |ilable system preference. |`AllowRenewalIfOtherItemsAv |It has two options - allow |ailable` system preference. |renewal if other items are |It has two options - allow |available to fill holds at |renewal if other items are |any library, or only at the |available to fill holds at |hold's pickup library. This |any library, or only at the |way, if items cannot be |hold's pickup library. This |shared between libraries, |way, if items cannot be |the |shared between libraries, |AllowRenewalIfOtherItemsAva |the |ilable system preference |`AllowRenewalIfOtherItemsAv |will consider this when |ailable` system preference |deciding if renewal is |will consider this when |allowed. |deciding if renewal is | |allowed. Version|unspecified |Main --- Comment #33 from Katrin Fischer <[email protected]> --- 1) QA checks - pass! 2) Code review a) Database update Won't print message in green, since it's missing: use Koha::Installer::Output qw(say_warning say_success say_info); Fixed in follow-up. b) System preference check (question) + if ( C4::Context->preference('AllowRenewalIfOtherItemsAvailableLocation') + and C4::Context->preference('AllowRenewalIfOtherItemsAvailableLocation') eq 'holdbranch' ) + { It seems like the second check would be enough since the only valid values of the pref are any and holdbranch? 3) Testing Works as expected. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
