https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Extended notice |Extended notice release notes|message_transport_type |message_transport_type |fallback functionality |fallback functionality |implemented by |implemented by |FallbackToSMSIfNoEmail |FallbackToSMSIfNoEmail |system preference to: |system preference to: |cronjobs (membership |- cronjobs (membership |expiry, automatic renewal), |expiry, automatic renewal), |opac-shareshelf.pl (sending | |of SHARE_ACCEPT notice when |- opac-shareshelf.pl |list share accepted), |(sending of SHARE_ACCEPT |circ/pendingreserves.pl |notice when list share |(sending |accepted), |'CANCEL_HOLD_ON_LOST' |- circ/pendingreserves.pl |notice when reserved item |(sending |marked lost in Holds to |'CANCEL_HOLD_ON_LOST' |pull), C4/Acquisition.pm |notice when reserved item |(sending |marked lost in Holds to |'ACQ_NOTIF_ON_RECEIV' |pull), |notice to notify order user |- C4/Acquisition.pm |of order receival) |(sending | |'ACQ_NOTIF_ON_RECEIV' | |notice to notify users of | |receipt) Status|Needs Signoff |Failed QA --- Comment #30 from Katrin Fischer <[email protected]> --- 1) QA checks - failing 2 minor fails noted by the QA tests: Your branch is up to date with 'origin/main'. testing 2 commit(s) (applied to 1534574 '574 Bug 39745: Fix wrong system prefe') Processing files [RUNNING] C4/Acquisition.pm [RUNNING] C4/Suggestions.pm [RUNNING] Koha/Patron.pm [RUNNING] circ/pendingreserves.pl [RUNNING] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref [RUNNING] opac/opac-shareshelf.pl [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref [PASS] opac/opac-shareshelf.pl [PASS] circ/pendingreserves.pl [PASS] C4/Acquisition.pm [FAIL] Koha/Patron.pm [PASS] C4/Suggestions.pm Result: [PASS] C4/Acquisition.pm [PASS] C4/Suggestions.pm [FAIL] Koha/Patron.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/Patron.pm` [PASS] circ/pendingreserves.pl [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref FAIL new_line_at_the_end_of_file Missing new line at the end of file, make sure your editor correctly reads .editorconfig ('insert_final_newline = true'). See bug 40541. [PASS] opac/opac-shareshelf.pl 2) Code review (blocker for QA) - Missing unit tests. 3) Testing a) General notes (question) Since SMS messages are usually not free, I wonder if this should allow to specify which notices the fallback should be applied to automatically. A library might want to opt out for some, but not for all notices to be sent by SMS. We might also break the use case of the library who first implemented the pref... as we would change the behavior with no option to change it back. So it would be nice to have some feedback. (@Alex Buckley?) b) Missing SMS notice template? (question) What is supposed to happen when there is no SMS template set up for the notice, will it not be sent? (which would be way to opt out of the fallback) c) System preference phrasing (suggestions/questions) We currently have: [Enable|Disable] sending notices by SMS if patron has no email address. I wonder if this might be a little clearer: [Send|Don't send] notices by SMS if patron has no email address. It also makes it sound like the fallback will always be applied for all notices to patrons. But there are some notices missing from the list given in the release note. I feel like we should be clear about what is covered, at least for documentation Some notices that came to mind: - advance notices - overdue notices - hold/booking/recall pick-up notice - hold cancellation notice - article request notices If we made this opt-in by notice/area, the option list could also serve as documentation. The second patch says: "We also drop the fallback for the expiry notice, as a bug has since introduced functionality to send to both email and sms for that notice.", but it's still listed in release note. Also wondering: if it includes an automatic fallback, should that not also be under the pref? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
