https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36506
--- Comment #19 from Martin Renvoize (ashimema) <[email protected]> --- Comment on attachment 187578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187578 Bug 36506: Use new rules in C4::Accounts Review of attachment 187578: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36506&attachment=187578) ----------------------------------------------------------------- ::: C4/Accounts.pm @@ +78,5 @@ > + my $lost_control_branch; > + if ( $lost_control_pref eq 'PatronLibrary' ) { > + $lost_control_branch = $patron->branchcode; > + } elsif ( $lost_control_pref eq 'PickupLibrary' ) { > + $lost_control_branch = C4::Context->userenv ? > C4::Context->userenv->{'branch'} : undef; Can you explain the reasoning here.. a lost item won't necessarily be related to a hold.. so I get we can't easily pass a PickupLibrary and I understand using the userenv.. i.e. your using 'PickupLibrary' to mean 'Library the patron is standing in' if this is getting charged via the UI.. but when that's not the case.. i.e. when running from a cron?. Does it really make sense to fall back to the 'default rule for all libraries' if set.. or should we instead fall back to the patrons home library on the assumption they'd 'Pickup' from their home branch? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
