https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40869
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <[email protected]> --- Reading through the test plan I wonder if this is the right solution or not. I can see the merit for values like homebranch/holdingbranch. We usually use a "Default" with the branchcode for these, but don't set the fields to mandatory. My first reaction would be, that we should display an error message somewhere if a mandatory field is hidden from a form on saving. I believe that would match the behavior we see in other places like patron self registration. If we move on with this: 1) QA tests fail (tidy) 2) Unit tests were updated for the name change, but I feel there should be additional tests for the difference between mandatory and optional hidden fields as well (up to QA) (setting failed QA to raise attention of the developer and for 1) and 2). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
