https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35612
--- Comment #36 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 192513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192513&action=edit Bug 35612: Recorded branch context for OVERDUE, LOST, and PROCESSING fees This patch ensures that the accountlines.branchcode field correctly records which branch's circulation rules were applied when creating OVERDUE, LOST, and PROCESSING fee debits. Previously, this field was often NULL or set to the logged-in user's branch, making it difficult to track which branch's policies governed the fee calculation. Changes made: 1. New helper method: Koha::Checkout->branch_for_fee_context() - Centralizes branch resolution logic based on system preferences - For LOST/PROCESSING: honors LostChargesControl preference - For OVERDUE: honors CircControl preference - Respects HomeOrHoldingBranch when choosing item's branch - Supports both Koha objects and plain hashrefs - Returns branchcode or undef if context unavailable 2. C4::Accounts::chargelostitem() - Now accepts optional $opts hashref parameter - Accepts interface, library_id, and issue_id in options - Determines appropriate branch using branch_for_fee_context - Passes resolved branch to add_debit as library_id - Issue_id lookup handles bundled items correctly 3. C4::Circulation::LostItem() - Calls branch_for_fee_context before chargelostitem - Passes interface context ('cron' for cronjob, otherwise current) - Passes resolved branch and issue_id to chargelostitem 4. C4::Overdues::UpdateFine() - Calls branch_for_fee_context to determine OVERDUE branch - Passes result as library_id to add_debit - Resolves long-standing FIXME about branch selection 5. misc/cronjobs/longoverdue.pl - Determines branch context before marking items lost - Passes library_id to LostItem when charging fees The branch resolution logic respects these system preferences: - CircControl: PatronLibrary | PickupLibrary | ItemHomeLibrary - LostChargesControl: PatronLibrary | PickupLibrary | ItemHomeLibrary - HomeOrHoldingBranch: homebranch | holdingbranch Test plan: 1. Create three test libraries (e.g., FPL, CPL, PVL) 2. Create a test patron with home library PVL 3. Create an item with: - homebranch = FPL - holdingbranch = CPL 4. Set system preferences: - FinesMode: Calculate and charge - Create circulation rule that charges overdue fines 5. Test OVERDUE fees with CircControl: a. Set CircControl = PatronLibrary, HomeOrHoldingBranch = homebranch b. Check out item to patron at CPL, backdate to be overdue c. Run: perl /usr/share/koha/bin/cronjobs/fines.pl d. Check accountlines: SELECT accountlines_id, branchcode, debit_type_code FROM accountlines ORDER BY accountlines_id DESC LIMIT 5; e. Verify branchcode = PVL (patron's home library) f. Delete the fine, repeat with CircControl = PickupLibrary g. Verify branchcode = CPL (checkout library) h. Delete the fine, repeat with CircControl = ItemHomeLibrary i. Verify branchcode = FPL (item's home library) j. Change HomeOrHoldingBranch = holdingbranch, repeat k. Verify branchcode = CPL (item's holding library) 6. Test LOST fees with LostChargesControl: a. Set WhenLostChargeReplacementFee = Charge b. Set item replacement price > 0 c. Ensure item is checked out to patron d. Set LostChargesControl = PatronLibrary e. Mark item as lost in staff interface f. Check accountlines for LOST debit g. Verify branchcode = PVL (patron's home library) h. Return item, re-checkout, repeat with LostChargesControl = PickupLibrary i. Verify branchcode = CPL (checkout library) j. Repeat with LostChargesControl = ItemHomeLibrary + homebranch k. Verify branchcode = FPL (item's home) l. Repeat with LostChargesControl = ItemHomeLibrary + holdingbranch m. Verify branchcode = CPL (item's holding) 7. Test longoverdue cronjob: a. Re-checkout item with due date triggering longoverdue b. Run: perl /usr/share/koha/bin/cronjobs/longoverdue.pl --lost 30=1 --charge 1 --confirm --verbose c. Verify LOST debit created with correct branchcode per LostChargesControl 8. Test edge cases: - WhenLostChargeReplacementFee = Don't charge → no LOST debit - Replacement price = 0 → no LOST debit - FinesMode = Don't calculate → no OVERDUE debits Signed-off-by: Trevor Diamond <[email protected]> Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
