https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956
--- Comment #77 from David Nind <[email protected]> --- I've signed off, but one thing I don't really understand is what should be shown in the log viewer - versus what is recorded in the database. For example: 1. I added and removed superlibrarian permissions for Henry. 2. What is shown in the log viewer vs what is in the database: - Added: . Log viewer: {"superlibrarian":1} . Database diff column: {"D":{"superlibrarian":{"A":1}}} - Removed: . Log viewer: {} . Database diff column: {"D":{"superlibrarian":{"R":1}}} 3. What is shown in the info column in the log viewer is almost meaningless/useless for a "normal" staff patrons - unless you know what it means, or can access the database/run a report to show the diff. Which, in my view, defeats the purpose of logging permission changes. While you can show the diff column, the info column should at least provide reasonably understandable information on what was changed, for example: XYZ permission added or removed. Also, as I am not a developer, I have no idea for the test patches how to: - Confirm the test now properly validates the intended behavour - Confirm permissions() now returns all flags with 0/1 values Feel free to change back to needs sign off if this is something that you require a tester to do. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
