https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41076
--- Comment #21 from Jonathan Druart <[email protected]> --- (In reply to Marcel de Rooy from comment #20) > Just a side note but just intrigued by the first perltidy change in Auth.pm: > @@ -1236,7 +1236,7 @@ sub checkauth { > : Koha::Cash::Registers->search( > { branch => $branchcode, branch_default => 1 }, > { rows => 1 } > - )->single; > + )->single; > > I would have preferred to indent the two lines after ->search here.. Now the > search parameters in the ternary else branch are on the same level as the > single applied on the whole ternary result. Martin asked the same on Mattermost: https://chat.koha-community.org/koha-community/pl/4j1pnibow7n9tdhcjddgzs1w4c The whole statement (now): 1233 my $register = 1234 $query->param('register_id') 1235 ? Koha::Cash::Registers->find( $query->param('register_id') ) 1236 : Koha::Cash::Registers->search( 1237 { branch => $branchcode, branch_default => 1 }, 1238 { rows => 1 } 1239 )->single; 1239 was definitely wrong, and it's fixed now. However I do agree that 1237 and 1238 should have an additional indent level. Maybe it will be fixed in the next update? :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
