https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492
--- Comment #77 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 192905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192905&action=edit Bug 3492: (follow-up) Replace GetReserveFee with holds_fee method GetReserveFee was removed as part of the migration to circulation rules-based hold fees, but reserve/request.pl still imported and used it, causing compilation errors. This patch replaces the two usages of GetReserveFee with the modern approach using Koha::Item->holds_fee($patron), matching the implementation in opac-reserve.pl. The fee is calculated by iterating through available items and using the first non-zero fee found, which provides backward compatibility with the legacy reserve_charge template variable. This implementation uses ReservesControlBranch to determine which branch's circulation rules apply (either item home library or patron home library), consistent with the existing Koha policy framework. Test plan: 1. Apply patch 2. Verify reserve/request.pl compiles: perl -wc reserve/request.pl 3. Navigate to staff interface holds page with patron and biblio 4. Verify hold fee is displayed correctly if configured in circulation rules 5. Place a hold and verify fee is charged correctly -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
