https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38384
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #55 from Marcel de Rooy <[email protected]> --- Looks good to me. Just a few minor questions: - my $verbose = $params->{verbose} // $class->_verbose; Removed. Verbose test still passes. So seems to be OK. + my $cache_key = 'enabled_plugins'; Constant? + # Test caching behavior + my @plugins_cached = Koha::Plugins::Loader->get_enabled_plugins(); + is( scalar @plugins_cached, 0, 'Cached empty result works correctly' ); When paranoid, you could still doubt if the cache was really used? And what about this line: Koha::Cache::Memory::Lite->set_in_cache( $cache_key, \@plugins ) if @plugins; This shows that an empty result is not even cached ! So this test is misleading.. Should we remove the if @plugins or adjust the test? t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t ... 1/7 # Looks like you planned 6 tests but ran 4. # Failed test 'after_biblio_action() and after_item_action() hooks tests' # at t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t line 92. [Foreign key constraint broken on deleting resource]# Looks like your test exited with 255 just after 5. t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t ... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/7 subtests => Fails for me too without this patch set.. So ignoring. Although it seems bit out of scope, C4::Context was initially modified here. It does call Koha::Database but it does not include a use or require of that module. That looks wrong. (It comes with Koha::Config::Sysprefs -> Koha::Objects.) Should we formally add it here too? And perhaps reorder the modules? Changing status for feedback. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
