https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38425
--- Comment #13 from Alexander Wagner <[email protected]> --- AFAIS one could indeed do it with the procedures of Bug 39860. But then you'd need to do it on every instance individually, right? It moves more from a default behaviour to some customization. Indeed, if we do not want it as a default behaviour of Kohas, I'd go with 39860 on our instances once it is in the upcoming stable, so thanks for this pointer :) Anyway, my main concern with the hard coded links was the hard-coding of "magic strings". This is IMHO not nice, and also does not scale well if new ids should be added. OTOH for the use case here it's also not entirely bad, as it refers to base-URLs of PID-resolvers. So, yes, `http://dx.doi.org/` should read `https://doi.org/` these days, but this was also the only change of this kind we experienced in our old system in the past 10 years or so. Probably, I changed a few http calls to https as well, which is also not that common and mainly a point for not storing https://doi.org/<doi>, but just the DOI and leave the rest to the display logic. And of course one could streamline the code if we could just use a hash for the base urls. Something like `{'doi': 'https://doi.org/%s', 'pmid': 'https://pubmed.ncbi.nlm.nih.gov/%s'}` and loop over it. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
