https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415
--- Comment #237 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 193091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193091&action=edit Bug 23415: (follow-up) Rename sysprefs and add self-checkout control This follow-up patch addresses feedback from the QA process: 1. System preference naming consistency Renamed the following preferences to remove "OPAC" prefix and align with the FineNoRenewals naming convention: - OPACFineNoRenewalsIncludeCredits → FineNoRenewalsIncludeCredits - OPACFineNoRenewalsBlockAutoRenew → FineNoRenewalsBlockAutoRenew 2. Self-checkout backward compatibility Added new system preference FineNoRenewalsBlockSelfCheckRenew to control whether fine limits block renewals via web-based self-checkout. Previously, OPACFineNoRenewals did not block self-checkout renewals. With the rename to FineNoRenewals, this behavior changed. The new preference defaults to "0" (don't block) to maintain backward compatibility, allowing sites to opt-in to blocking self-checkout renewals when patrons exceed the fine threshold. Test plan: 1. Run prove t/db_dependent/Circulation.t - all tests should pass 2. Run prove t/db_dependent/api/v1/checkouts.t - all tests should pass 3. Verify system preferences are correctly renamed in the admin interface 4. Test self-checkout renewals with FineNoRenewalsBlockSelfCheckRenew set to 0 (default) - renewals should work even when fines exceed limit 5. Test self-checkout renewals with FineNoRenewalsBlockSelfCheckRenew set to 1 - renewals should be blocked when fines exceed limit Sponsored-by: OpenFifth <https://openfifth.co.uk/> Signed-off-by: Andrew Fuerste Henry <[email protected]> Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
