https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269
--- Comment #51 from Pedro Amorim <[email protected]> --- Passing QA as everything appears to be working as intended and this adds great value to Koha. I have some minor comments which I don't think are blockers and up to you Johanna if you feel they're worth following up on or not! 1) FIXME: in holds_table.inc I think we can remove this about form-submit.js as is included in js_includes.inc so should be always available everywhere. 2) request.tt and request.pl It appears 'total_holds' is replacing 'reserveloop'. If this is the case, we should cleanup the remaining instances of reserveloop in both files. 3) Could use new API tests under 'edit' in t/db_dependent/api/v1/holds.t to test new params (item_level, item_id) 4) Hold::item_level_holds missing tests, possibly better renamed to item_level_holds_count -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
