https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40504
--- Comment #54 from Pedro Amorim <[email protected]> --- (In reply to Lisette Scheer from comment #40) > Suggestions doesn't work as expected. > This doesn't happen: > Notice the 'Managed by' is showing 'You', with the message 'Previously was > Edna Acosta'. This is the desired behavior mimicked from Suggestions i.e. > the staff member that is editing the request details is assumed to becomes > it's manager by default. The staff member must click 'Keep existing manager' > if they want to submit changes without changing the request's manager. Test > buttons, save, verify that it all works. Hi Lisette, thank you for looking here. I had to rebase on bug 39721 and bug 33544 plus filed a fix that I believe is caused by bug 39721 (bug 41857) and only then I was able to follow the test plan here. I followed the test plan again (after the above) and I can't find anything wrong in suggestions as you mentioned, can you please test again or please clarify exactly what's wrong. > Also the table shows last modification by as the same as the manager even if > was, for example, koha making edna the manager. I believe this is beyond the scope of this patchset as Koha::Suggestion->last_modifier is just returning self->_result->managedby i.e. exactly the same as Koha::Suggestion->manager i.e. the table showing the same patron for both columns appears to be working as intended but even if not, it's not something introduced in this patchset. Happy to be proven wrong and follow-up if so of course. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
