https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30144
--- Comment #21 from Kyle M Hall (khall) <[email protected]> --- Created attachment 193323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193323&action=edit Bug 30144: Add tests for EDIFACT servicing instruction handling This commit adds comprehensive tests for servicing instruction processing in both incoming quotes and outgoing orders: 1. Integration tests for incoming quote processing (Koha/EDI.pm) - Tests LVC (coded) and LVT (freetext) extraction - Tests multiple GIR occurrences with different servicing instructions - Tests all combinations: LVC only, LVT only, and LVC+LVT together 2. Test EDIFACT quote file (QUOTES_SERVICING.CEQ) - Contains 3 line items with 4 total orders - Demonstrates different servicing instruction patterns 3. Fix for multi-occurrence servicing instruction extraction - Modified quote_item() to extract servicing instructions per GIR occurrence instead of across all occurrences - Ensures each order gets only its own servicing instructions - Aligns with existing multi-item processing for funds and stock rotation Test coverage: - t/db_dependent/Koha/EDI.t: 29 tests for incoming quote processing - t/db_dependent/Koha/Edifact/Order.t: 18 tests for outgoing order generation (previously added) All tests pass successfully. Sponsored-by: Martin Renvoize <[email protected]> Signed-off-by: Kyle M Hall <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
