https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41887
--- Comment #2 from David Nind <[email protected]> --- Created attachment 193531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193531&action=edit Bug 41887: Skip clash detection on terminal status transition - Booking::store runs item-level and biblio-level clash detection unconditionally on every call - During checkout, C4::Circulation sets the booking status to 'completed' and calls ->store(), which triggers clash checks - Combined with false positives from Biblio::check_booking (e.g. checkouts on non-bookable sibling items inflating the unavailable count), this throws Koha::Exceptions::Booking::Clash resulting in a 500 error - Running clash detection on a terminal transition is unnecessary regardless; skip it for cancelled/completed - Add _is_final_status_transition() helper that inspects the dirty columns to detect completed/cancelled transitions - Guard both clash detection blocks with the new helper To test: 1. Have a biblio with two items: one bookable, one not (bookable = 0). 2. Create a booking on the bookable item. 3. Check out the non-bookable item to a patron. 4. Check out the bookable item to the booking patron (this triggers the completed transition via C4::Circulation). 5. Without the patch: 500 error from Koha::Exceptions::Booking::Clash. 6. Apply the patch. 7. Repeat steps 2-4. 8. Verify the checkout succeeds and the booking transitions to completed. 9. Run: prove t/db_dependent/Koha/Booking.t and confirm the new subtest "store() skips clash detection on terminal status transition" passes. Signed-off-by: David Nind <[email protected]> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
