https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020
--- Comment #37 from Katrin Fischer <[email protected]> --- 1) QA checks - failing Processing additional checks * Author 'John Doe' seems invalid * Author 'John Doe' seems invalid * Email's author '[email protected]' seems invalid * Email's author '[email protected]' seems invalid This is not visible in git/tig as we do have mappings for John Doe to Kyle. Still might worth fixing in case it's sometime not Kyle :) Other checks and unit tests are passing. 2) Database update - missing say_success (consistency) - Doesn't use BEFORE/AFTER. It's added as last column to the end of the table and it's unlikely to be backported, so this might be a non-issue here. 3) Permission checks (question/suggestion) We could add a permission check here, but not sure if it's needed: + <div class="hint"> Select a file transport configuration for this EDI account. File transports can be managed in <a href="/cgi-bin/koha/admin/file_transports.pl">Administration › File transports</a>. </div> 3) Testing Did somewhat limited testing, but trying to give this a push. Maybe Tomas can finish off here when he is back? (see QA contact). a) Administration > MARC order accounts - OK can be saved without file transfer set - OK can be saved with file transfer set - Seems all good. b) Cron job I was wondering: When setting up the file transport you configure a path for the upload and download of files. But it looks like the MARC order accounts might not be using it. I left "Download directory" empty in the MARC order account. Test run only Fetching MARC ordering accounts Starting MARC ordering process for My Vendor Looking for new files in Can't open filepath at ./marc_ordering_process.pl line 159. Got a bit stuck here missing a file to use. If you could provide one and a bit more detailed test plan, i am happy to continue here. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
