https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21941

--- Comment #8 from Kevin Carnes <[email protected]> ---
Created attachment 193716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193716&action=edit
Bug 21941: Fix GROUP BY in circ/reserveratios.pl

When using strict_sql_modes, the Hold ratios page causes an Incorrect GROUP BY
error and returns an Error 500.

This patch removes uncessary columns from the database query and adds the
biblio columns to the GROUP BY statement, so they can be selected. Since it's
already grouped by biblionumber, it should not cause any additional rows to be
created.

Test plan:
1. Make sure that strict_sql_modes is enabled in the koha-conf.xml file.
2. Place at least one hold on a book.
3. Go to Circulation and select Hold ratios.
4. Observe that you get an Error 500.
5. Apply patch.
6. Repeat step 3.
7. Observe that you can view the page.
8. If the table is empty, change the ratio to 1.
9. Sign off.

Sponsored-by: Lund University Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to