https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41917
--- Comment #6 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 193799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193799&action=edit Bug 41917: (QA follow-up) Fix effective_bookable item-level override The previous implementation used the // (defined-or) operator then checked !$bookable, which could not distinguish between an explicit item-level bookable=0 and an inherited itemtype bookable=0. Both triggered the parent itemtype fallback, allowing a bookable parent to override an item explicitly marked as not bookable. Fix by returning item->bookable immediately when it is defined (0 or 1), so the parent fallback is only reached when item->bookable is NULL. Also caches $self->itemtype in a local variable, consistent with the effective_not_for_loan_status pattern. Adds a missing test: item bookable=0 with a bookable parent itemtype should still return 0. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
