https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41521
--- Comment #31 from David Cook <[email protected]> --- Anyway... I'm just splitting hairs a bit I think so let's not worry about my comment there. Like Jonathan said we can always change that later if need be. "prove xt/pl_valid.t" takes a long time to run... I ran it to reproduce the original warning messages but to prove it after applying the patch I just did the following: perl -cw Koha/ExternalContent/OverDrive.pm perl -cw opac/external/overdrive/auth.pl perl -cw opac/svc/overdrive -- I'm not sure I understand the changes to Koha/Devel/Files.pm but I'm not too worried about that. Maybe it just means that we don't fail the "qa" tools for fails? Otherwise... changes look fairly straightforward. The warnings go away after the patch. I trust Jonathan and Victor but I figure I'll do a quick comparison of the modules anyway using "diff -r /usr/share/perl5/WebService/ lib/WebService/" Changes are minimal and logical, and they eliminate the problem. Looks solid. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
