https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37829
Thibaud Guillot (thibaud_g) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181040|0 |1 is obsolete| | --- Comment #31 from Thibaud Guillot (thibaud_g) <[email protected]> --- Created attachment 193846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193846&action=edit Bug 37829: Add additional fields support to modal, tables To test: 1) Setup: a) Apply the db seed provided: koha-mysql < test_bug_37829.sql --- or --- b) Setup authorised values and additional fields manually: i) Navigate to Administration -> Authorized Values and click '+ New Category'. ii) Define a new authorised value category (e.g., prefix with BOOKINGS_ for easy identification). iii) Click '+ Add a new authorized value'. iv) Add a value, filling in at least 'Authorized Value' and 'Description'. v) Save the value. vi) Navigate to Administration -> Additional Fields. vii) Click 'Bookings (bookings)'. viii)Click '+ New field'. ix) Add a plain text field (fill 'Name' and save). x) Add a repeatable text field. xi) Add a field tied to your previously created authorized value category. xii) Add another field tied to any authorised value (e.g., YES_NO) and make it repeatable. 2) Item Configuration: Make an item bookable. Either: a) Navigate to Administration -> Item types, select an item type (e.g., BK), and check 'bookable'. b) Navigate to the 'Items' view for a specific item (catalogue/moredetail.pl) and set Priority -> Bookable -> 'Yes'. 3) Create Booking: Click the 'Place booking' button on the item's record. The configured additional fields should load dynamically in the modal. 4) Fill and Save Booking: Fill out the default booking fields and then the additional fields. Use the 'Remove' and 'New' buttons for repeatable fields. Save the booking. 5) Verify Display in Tables: Confirm that the additional fields for the booking are displayed correctly in the following locations: a) The bookings table within the bibliographic record's detail view. b) The 'Check out' view (circ/circulation.pl -> Bookings tab). c) The 'Patron's details' view (members/moremember.pl -> Bookings tab). d) The 'Bookings to collect' view (circ/pendingbookings.pl) (adjust filters if necessary). 6) Verify Edit/Move Functionality: Return to the bookings view of the bibliographic record. a) Verify the additional fields are correctly pre-filled and saved when you move the booking using the timeline component. b) Verify the additional fields are correctly pre-filled and saved when you edit the booking using the edit button in the bookings table. 7) Repeat Testing: Repeat steps 4 through 6.b with additional bookings to ensure consistency. 8) Sign-off and/or give your feedback. Here's some things I'd would still like to improve/try: - Incorporate the neighboring additional-fields-entry.js to have a single library for additional fields - Restructure the buttons to be consistent with other usage of additional fields in Koha (noticed this way to late) - Test this with the freshly added support for additional fields on branches (libraries) - Make the additional field values searchable in the table - Clean up and DRY some of the JSDoc types (but this could easily become its own tree of bugs if done from the source :D) - Use mockData.js for the mocha tests instead of hardcoding them I actually need this for a customer and the current state will be alright for that, but now it's good enough to work and improve it together. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
